[runtime] Correct usage of add_custom_command_target in CMakeLists.txt #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- COMMAND arguments must immediately follow dependency_out_var_name. - Use generated target name instead of output file names. - Unify 2 file copy COMMAND into 1 add_custom_command_target.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
COMMANDarguments must immediately follow<dependency_out_var_name>. See here.COMMANDinto 1add_custom_command_target.In addition, changed the component of
libsection_magic_{begin,end}.atonever_installI believe
swift_{begin,end}.oare required, butlibsection_magic_{begin,end}.aare not for install.Please correct me if I was wrong.
Before merging this pull request to apple/swift repository: