[gardening] Slim down StmtChecker::visitSwitchStmt even more #23334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n helper method. The method StmtChecker::visitSwitchStmt is really large and does a bunch of different things. This implicit submethod was one of the largest of these. By extracting this, we make the original method easier to reason about. Extracting done with Xcode's refactoring engine.
…t into a helper method.
…types into its own helper method. This is the last "subroutine" I am extracting from StmtChecker::visitSwitchStmt. It is possible to read easily now without getting lost.
|
@swift-ci smoke test and merge |
gottesmm
commented
Mar 15, 2019
| @@ -947,6 +947,142 @@ class StmtChecker : public StmtVisitor<StmtChecker, Stmt*> { | |||
| return S; | |||
| } | |||
|
|
|||
| void checkCaseLabelItem(CaseStmt *caseBlock, CaseLabelItem &labelItem, | |||
| bool &limitExhaustivityChecks, Type subjectType) { | |||
| SWIFT_DEFER { | |||
There was a problem hiding this comment.
I am actually going to rip out the usage of SWIFT_DEFER here in a subsequent commit and hoist it back into visitSwitchStmt. I just don't want to stop the testing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just extracted out subroutines using Xcode's refactoring engine. Should be NFC.
Now one can actually read StmtChecker::visitSwitchStmt without getting lost since it is more compact.