swift-reflection-test: Target SwiftRemoteMirror C API #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
LLDB needs to update its use of readBytes. |
|
LLDB change: apple/swift-lldb#25 |
|
This doesn't need to change the C++ MemoryReader API; you can just change the C interfaces. |
|
Fair enough. |
|
@swift-ci Please smoke test |
| @@ -72,7 +72,7 @@ class CMemoryReader final : public MemoryReader { | |||
|
|
|||
| bool readBytes(RemoteAddress address, uint8_t *dest, uint64_t size) override { | |||
| return Impl.readBytes(Impl.reader_context, | |||
| address.getAddressData(), dest, size); | |||
| address.getAddressData(), dest, size) == 1; | |||
There was a problem hiding this comment.
Prevailing C convention is that you should be testing != 0.
There was a problem hiding this comment.
Cool - I'll fix it up before merging.
This tool should test the usage from SwiftRemoteMirror dylib and the C API, since that is the public interface from which we're vending the remote reflection functionality.
These tools are always architecture-specific and always match the architecture of the built Swift binary that links against SwiftReflectionTest, so they can statically reference the size of their pointer types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool should test the usage from SwiftRemoteMirror dylib and
the C API, since that is the public interface from which we're
vending the remote reflection functionality.