[syntax parser] Fix another assertion hit related to invalid composition type #23376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion type Found by the stress tester.
|
@swift-ci smoke test and merge |
|
This causes a regression on Windows! Seems that the compiler is crashing on Windows :-(. (or at least, this test started failing in the last two days). |
|
I seriously doubt that these changes introduced the crash. Could you file a JIRA with details of the crash ? |
To clarify, if we revert this and the crash goes away, all we'll have accomplished is hide the underlying crash. We might as well XFAIL it for Windows in such a case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by the stress tester.