[os_log][stdlib-private] Add tests for checking the correctness of buffer and format string construction in the new OS log APIs. #23437
Conversation
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please clean test |
|
@swift-ci Please test linux platform |
| h.log("\'Imagination is more important than knowledge\' - Einstein") | ||
| h.log("Imagination is more important than knowledge \n - Einstein") | ||
| h.log("Imagination is more important than knowledge - \\Einstein") | ||
| h.log("The log message will be truncated here.\0 You wont see this") |
There was a problem hiding this comment.
| h.log("The log message will be truncated here.\0 You wont see this") | |
| h.log("The log message will be truncated here.\0 You won't see this") |
| withUnsafeBytes(of: expectedData) { expectedBytes in | ||
| for i in 0..<Int(size) { | ||
| // Argument data starts after the two header bytes. | ||
| expectEqual(expectedBytes[i], buffer[startIndex + 2 + i]) |
There was a problem hiding this comment.
Probably to make a failure more useful, add a message to the expectEqual call, containing the index at which the mismatch happened.
| ) { | ||
| checkArgument( | ||
| startIndex: startIndex, | ||
| size: UInt8(Int.bitWidth / bitsPerByte), |
There was a problem hiding this comment.
| size: UInt8(Int.bitWidth / bitsPerByte), | |
| size: MemryLayout<UInt8>.size, |
| // A stress test that checks whether the log APIs handle messages with more | ||
| // than 48 interpolated expressions. Interpolated expressions beyond this | ||
| // limit must be ignored. | ||
| OSLogTestSuite.test("messages with too many arguments") { |
There was a problem hiding this comment.
These tests that don't call any expectXXXX fucntions, they can't really fail, can they? Is it possible to somehow validate the output produced by calling os_log? Maybe it can be done in a separate file that does not use StdlibUnitttest, and instead simply validates the stdout output... Just a thought. What do you think?
There was a problem hiding this comment.
Yeah, that's is right. We need to have some way of checking the logged messages. I will see how this could be done. As you say, we can't use StdlibUnittest. The logs don't get printed to stdout by default and may require registering a stream handler. I will create a new PR for that.
buffer and format string construction in the new OS log APIs.
ravikandhadai
force-pushed
the
loggingAPI-PR
branch
from
1cb5d23 to
2f2afd0
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test and merge |
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
|
@swift-ci Please test Linux Platform |
|
Build failed |
|
@swift-ci Please test Linux platform |
No description provided.