test: improve test coverage rate for Windows #23466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip the use of `env` on Windows which will swallow the error code if the GnuWin32 version (which is recommended/used by LLVM) is used. Since SDKROOT should not be set on Windows anyways, this should not matter much in practice but will help improve the test coverage on Windows. Additionally, remove the path lowercasing on Windows as the path is kept in the proper case, even on the nightlies. This should help improve the number of Driver tests that pass. With this change, I now can get all the Driver tests to pass locally.
|
CC: @jmittert |
|
Thanks! Looks good to me, I'll see if I can figure out why my system was lowercasing path names. |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip the use of
envon Windows which will swallow the error code ifthe GnuWin32 version (which is recommended/used by LLVM) is used. Since
SDKROOT should not be set on Windows anyways, this should not matter
much in practice but will help improve the test coverage on Windows.
Additionally, remove the path lowercasing on Windows as the path is kept
in the proper case, even on the nightlies. This should help improve the
number of Driver tests that pass.
With this change, I now can get all the Driver tests to pass locally.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.