[ParseableInterface] Honor "exported module names" #23474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::string -> StringRef of long-lived backing storage. No functionality change.
It's a pretty obscure feature (and one we wish we didn't need), but sometimes API is initially exposed through one module in order to build another one, and we want the canonical presented name to be something else. Push this concept into Swift's AST properly so that other parts of the compiler stop having to know that this is a Clang-specific special case. No functionality change in this commit; will be used in the next commit.
|
@swift-ci Please test |
(as described in the previous commit) When printing an interface that has to be stable, we need to use the module name that identifies where declarations should be searched for, just like we do with serialization. rdar://problem/49114811
jrose-apple
force-pushed
the
export-au-prince
branch
from
6e236e0 to
0366343
Compare
|
@swift-ci Please test |
|
Build failed |
harlanhaskins
approved these changes
Mar 21, 2019
|
Build failed |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Mar 22, 2019
[ParseableInterface] Honor "exported module names" (cherry picked from commit d8df1bf)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Mar 22, 2019
[ParseableInterface] Honor "exported module names" (cherry picked from commit d8df1bf)
|
This caused a regression on the Windows tests! |
|
:-( What was it? Did I do something too shell-y again? |
jrose-apple
added a commit
that referenced
this pull request
Mar 22, 2019
[ParseableInterface] Honor "exported module names" (cherry picked from commit d8df1bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's "exported module name" is a pretty obscure feature (and one we wish we didn't need), but sometimes API is initially exposed through one module in order to build another one, and we want the canonical presented name to be something else. Push this concept into Swift's AST properly, then use that name when printing a parseable interface, just like we do with serialization.
rdar://problem/49114811