Skip to content

test: use #include rather than #import #23486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

compnerd
Copy link
Member

#import is an extension which behaves differently in different target. On
Windows, it is used to import type libraries (for COM). The options are to
either use #include or enable Objective-C interop. Use the former since there
is no Objective-C specific behaviour needed here.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

`#import` is an extension which behaves differently in different target.  On
Windows, it is used to import type libraries (for COM).  The options are to
either use `#include` or enable Objective-C interop.  Use the former since there
is no Objective-C specific behaviour needed here.
@compnerd compnerd force-pushed the importing-is-not-inclusive branch from b3aae03 to 8e5e32b Compare March 22, 2019 16:50
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd compnerd merged commit a405948 into swiftlang:master Mar 22, 2019
@compnerd compnerd deleted the importing-is-not-inclusive branch March 22, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant