Skip to content

[android][test] Disabling autolinking tests for Android AArch64 #23551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

drodriguez
Copy link
Contributor

@drodriguez drodriguez commented Mar 25, 2019

The OS sadly changes between Android ARMv7 and Android AArch64, to
avoid this and any future problems, mark the autolinking tests that
I can find with UNSUPPORTED: autolink-extract, which should apply
to all platforms that need autolink-extract.

This should remove these tests from failing in Android 64.

@drodriguez drodriguez requested a review from compnerd March 25, 2019 23:49
The OS sadly changes between Android ARMv7 and Android AArch64, to
avoid this and any future problems, mark the autolinking tests that
I can find with `UNSUPPORTED: autolink-extract`, which should apply
to all platforms that need autolink-extract.

This should remove these tests from failing in Android 64.
@drodriguez drodriguez force-pushed the android-disable-autolinking-tests-aarch64 branch from b60aea9 to 17b9ad6 Compare March 25, 2019 23:59
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet these tests predate that feature; that's a better one anyway.

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@jrose-apple jrose-apple self-assigned this Mar 26, 2019
@compnerd
Copy link
Member

Agreed, this is better.

@compnerd
Copy link
Member

@swift-ci please smoke test and merge

@rintaro
Copy link
Member

rintaro commented Mar 26, 2019

@swift-ci Please smoke test

@jrose-apple jrose-apple merged commit e649beb into swiftlang:master Mar 26, 2019
@drodriguez drodriguez deleted the android-disable-autolinking-tests-aarch64 branch April 8, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants