-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[lit] Stub out lit feature detection on non-Apple platforms #23570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
Build failed |
This temporarily disables the following two tests to unbreak the Linux CI build. Swift(linux-x86_64) :: Sanitizers/witness_table_lookup.swift Swift(linux-x86_64) :: Sanitizers/tsan.swift
50c82a5
to
ff16bb8
Compare
@swift-ci Please test Linux |
@swift-ci Please smoke test osx |
@jrose-apple Are you okay with the updated patch? This should unblock #23508 |
I'm a little iffy on whether or not this will work because I'm not sure if we're consistent about "dispatch" meaning "Swift Dispatch" or "C Dispatch", but maybe it won't matter. It's okay for unblocking your other work, though, so go for it. |
Good point. Here (the lit feature) means "Swift Dispatch", i.e., everything required for |
This broke the test suite on Windows! https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=823 |
Can you, uh, tell us how it broke the test suite on Windows? |
|
Quick fix for an oversight on my part that slipped through CI in my previous PR (#23455): the TSan runtime now has a link-time dependency on libdispatch (unfortunately).
This temporarily disables the following two tests on Linux to unbreak CI build.
Swift(linux-x86_64) :: Sanitizers/witness_table_lookup.swift
Swift(linux-x86_64) :: Sanitizers/tsan.swift
The above two tests are also the only 2 TSan (executable) tests that are run on Linux. Once I fix the TODO mentioned in this PR, I will go through all
REQUIRES: tsan_runtime
occurences and try to enable them by using libdispatch/foundation instead of objc_interop.