[5.1] [CSDiagnostics] Improving the fix-it for defining computed properties #23589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #23500.
This PR offers an improvement when the user is trying to define a computed property that is initialised with a closure. For example:
We currently emit an error diagnostic for the above, with a fix-it to add
()
:In case of extensions, we emit:
With this change, we will offer another fix-it to convert it into a computed property, by removing the
=
and if the property is immutable, then also changing thelet
to avar
.Resolves SR-9267.