Skip to content

[ownership] Remove the -enable-mandatory-semantic-arc-opts flag now t… #23615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019
Merged

[ownership] Remove the -enable-mandatory-semantic-arc-opts flag now t… #23615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cmake/modules/SwiftSource.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,6 @@ function(_compile_swift_files
list(APPEND swift_flags "-Xfrontend" "-assume-single-threaded")
endif()

if(SWIFTFILE_IS_STDLIB)
list(APPEND swift_flags "-Xfrontend" "-enable-mandatory-semantic-arc-opts")
endif()

if(NOT SWIFT_ENABLE_STDLIBCORE_EXCLUSIVITY_CHECKING AND SWIFTFILE_IS_STDLIB)
list(APPEND swift_flags "-Xfrontend" "-enforce-exclusivity=unchecked")
endif()
Expand Down
3 changes: 0 additions & 3 deletions include/swift/AST/SILOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ class SILOptions {
/// Emit extra exclusvity markers for memory access and verify coverage.
bool VerifyExclusivity = false;

/// Enable the mandatory semantic arc optimizer.
bool EnableMandatorySemanticARCOpts = false;

/// Enable large loadable types IRGen pass.
bool EnableLargeLoadableTypes = true;

Expand Down
3 changes: 0 additions & 3 deletions include/swift/Option/FrontendOptions.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,6 @@ def pch_disable_validation : Flag<["-"], "pch-disable-validation">,
def disable_sil_ownership_verifier : Flag<["-"], "disable-sil-ownership-verifier">,
HelpText<"Do not verify ownership invariants during SIL Verification ">;

def enable_mandatory_semantic_arc_opts : Flag<["-"], "enable-mandatory-semantic-arc-opts">,
HelpText<"Enable the mandatory semantic arc optimizer">;

def suppress_static_exclusivity_swap : Flag<["-"], "suppress-static-exclusivity-swap">,
HelpText<"Suppress static violations of exclusive access with swap()">;

Expand Down
2 changes: 0 additions & 2 deletions lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,8 +771,6 @@ static bool ParseSILArgs(SILOptions &Opts, ArgList &Args,
Opts.DisableSILPartialApply |=
Args.hasArg(OPT_disable_sil_partial_apply);
Opts.VerifySILOwnership &= !Args.hasArg(OPT_disable_sil_ownership_verifier);
Opts.EnableMandatorySemanticARCOpts |=
Args.hasArg(OPT_enable_mandatory_semantic_arc_opts);
Opts.EnableLargeLoadableTypes |= Args.hasArg(OPT_enable_large_loadable_types);

if (const Arg *A = Args.getLastArg(OPT_save_optimization_record_path))
Expand Down