[stdlib] Fix availability of Dictionary’s bulk-loading initializer #23643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making it @_alwaysEmitIntoClient makes it available in all OS versions.
|
@swift-ci smoke test |
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Apr 3, 2019
The initializer was originally introduced without proper availability; in swiftlang#23643, we fixed this by applying the `@_alwaysEmitIntoClient` attribute. However, this had the unfortunate side-effect that the symbol disappeared from `libswiftCore.dylib`, which somehow confuses some simulator builds. Try to figure out what’s happening by replacing the third closure argument with an integer return value. This changes the mangled name of the bulk initializer, which should make it more obvious how/why these builds fail. rdar://problem/49479386
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Apr 3, 2019
The initializer was originally introduced without proper availability; in swiftlang#23643, we fixed this by applying the `@_alwaysEmitIntoClient` attribute. However, this had the unfortunate side-effect that the symbol disappeared from `libswiftCore.dylib`, which somehow confuses some simulator builds. Try to figure out what’s happening by replacing the third closure argument with an integer return value. This changes the mangled name of the bulk initializer, which should make it more obvious how/why these builds fail. rdar://problem/49479386 (cherry picked from commit e72e328)
lorentey
added a commit
that referenced
this pull request
Apr 3, 2019
The initializer was originally introduced without proper availability; in #23643, we fixed this by applying the `@_alwaysEmitIntoClient` attribute. However, this had the unfortunate side-effect that the symbol disappeared from `libswiftCore.dylib`, which somehow confuses some simulator builds. Try to figure out what’s happening by replacing the third closure argument with an integer return value. This changes the mangled name of the bulk initializer, which should make it more obvious how/why these builds fail. rdar://problem/49479386
lorentey
added a commit
that referenced
this pull request
Apr 3, 2019
The initializer was originally introduced without proper availability; in #23643, we fixed this by applying the `@_alwaysEmitIntoClient` attribute. However, this had the unfortunate side-effect that the symbol disappeared from `libswiftCore.dylib`, which somehow confuses some simulator builds. Try to figure out what’s happening by replacing the third closure argument with an integer return value. This changes the mangled name of the bulk initializer, which should make it more obvious how/why these builds fail. rdar://problem/49479386 (cherry picked from commit e72e328)
millenomi
pushed a commit
to swiftlang/swift-corelibs-foundation
that referenced
this pull request
Nov 11, 2020
The initializer was originally introduced without proper availability; in swiftlang/swift#23643, we fixed this by applying the `@_alwaysEmitIntoClient` attribute. However, this had the unfortunate side-effect that the symbol disappeared from `libswiftCore.dylib`, which somehow confuses some simulator builds. Try to figure out what’s happening by replacing the third closure argument with an integer return value. This changes the mangled name of the bulk initializer, which should make it more obvious how/why these builds fail. rdar://problem/49479386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These entry points were introduced in #21235. Adding
@_alwaysEmitIntoClientmakes them available in all OS versions.rdar://problem/49404177