[Driver] TSan runtime now has a link-time dependency on libdispatch #23645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the TSan runtime only required libdispatch on Darwin, which required no explicit linker flags, because libdispatch is always provided by the system (libSystem). Now, the TSan runtime also has a link-time dependency on libdispatch on Linux, where libdispatch (and the blocks runtime) is just another library. We therefore need to specify them as additonal linker options.
|
@swift-ci please test |
compnerd
reviewed
Mar 29, 2019
|
|
||
| // The TSan runtime depends on the blocks runtime and libdispatch. | ||
| if (context.OI.SelectedSanitizers & SanitizerKind::Thread) { | ||
| Arguments.push_back("-lBlocksRuntime"); |
There was a problem hiding this comment.
This is slightly worrisome. -fblocks-runtime-optional controls where you have a blocks runtime library or not that you link against. (The GNU ObjC runtime also provides the blocks runtime implicitly). I wish that we could delegate to the clang driver for the blocks runtime linkage.
There was a problem hiding this comment.
[...] delegate to the clang driver for the blocks runtime linkage.
This is what I am trying to do here. I don't really understand what you mean. What should we do instead?
|
Build failed |
|
@swift-ci please test Linux |
beccadax
reviewed
Apr 1, 2019
beccadax
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the TSan runtime only required libdispatch on Darwin, which
required no explicit linker flags, because libdispatch is always
provided by the system (via libSystem).
Now, the TSan runtime also has a link-time dependency on libdispatch on
Linux, where libdispatch (and the blocks runtime) is just another
library. We therefore need to specify them as additional linker options.