Skip to content

SILGen: explicitly state the constructor in use (NFC) #23670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

compnerd
Copy link
Member

MSVC found the constructor to be ambiguous here:

error C2668: 'swift::Lowering::PreparedArguments::PreparedArguments': ambiguous call to overloaded function
note: could be 'swift::Lowering::PreparedArguments::PreparedArguments(swift::Lowering::PreparedArguments &&)'
note: or       'swift::Lowering::PreparedArguments::PreparedArguments(llvm::ArrayRef<swift::AnyFunctionType::Param>)'
note: while trying to match the argument list '(initializer list)'

Explicitly state the constructor in use.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

MSVC found the constructor to be ambiguous here:

	error C2668: 'swift::Lowering::PreparedArguments::PreparedArguments': ambiguous call to overloaded function
	note: could be 'swift::Lowering::PreparedArguments::PreparedArguments(swift::Lowering::PreparedArguments &&)'
	note: or       'swift::Lowering::PreparedArguments::PreparedArguments(llvm::ArrayRef<swift::AnyFunctionType::Param>)'
	note: while trying to match the argument list '(initializer list)'

Explicitly state the constructor in use.
@compnerd
Copy link
Member Author

CC: @slavapestov

@compnerd
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit b75d835 into swiftlang:master Mar 29, 2019
@compnerd compnerd deleted the type-ambiguous-lists branch March 30, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants