Enable Child Memory Usage Tracking on Windows #23686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows requires a handle to get memory usage, so do a slight refactor to collect the child's memory usage as it exits instead of as the parent is cleaning up.
jrose-apple
approved these changes
Mar 31, 2019
|
@swift-ci Please smoke test |
|
Hmm, I suspect that this has caused a regression on the Windows test suite: Driver.batch_mode_parseable_output_cancellation fails after this: |
|
Bleh, I'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows requires a handle to get memory usage, so on Windows collect the child's memory usage as it exits instead of as the parent is cleaning up. This enables both Windows to output memory usage stats and causes
test/Misc/stats_dir_plausible_maxrss.swiftto pass on Windows.