[Diag] Consolidate «declared here» #23703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Apr 1, 2019
include/swift/AST/Decl.h
Outdated
| @@ -136,6 +136,7 @@ enum class DescriptiveDeclKind : uint8_t { | |||
| GenericStruct, | |||
| GenericClass, | |||
| GenericType, | |||
| ExtendedType, | |||
There was a problem hiding this comment.
I'm not sure about this unification. This isn't a kind of declaration any more; its saying something about how the declaration is used.
There was a problem hiding this comment.
Yeah, true. I wasn't sure either but was curious about your opinion. Let's reset.
AnthonyLatsis
force-pushed
the
consolidate-declared-here-diag
branch
from
8fd0405 to
4e0e209
Compare
jrose-apple
approved these changes
Apr 1, 2019
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the «declared here» messages for an
Identifierinto their equivalents forDeclName, to whichIdentifieris implicitly convertible (conversation).Thanks for noticing this, Jordan!
@jrose-apple