[5.1][SE-0248] String Gaps #23706
Merged
[5.1][SE-0248] String Gaps #23706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new (availability-controlled) API to Unicode.Scalar, exposing the scalar's UTF-8 code units as a random-access collection similarly to how it currently exposes UTF-16 code units. Tests added.
Adds a generic version of String.Index.init?(_:within:) and Range<String.Index>.init?(_:in:). Tests added
Adds these collections, which are just String's views. Tests added.
Adds Substring.base, analogous to Slice.base, to access the entire String. Tests added.
Add convenience APIs to the stdlib's Unicode encodings: * Unicode.UTF16 * isASCII * isSurrogate * Unicode.UTF8 * isASCII * width * Unicode.UTF32 * isASCII * Unicode.ASCII * isASCII Tests added
Bounds check the given index for String.Index's generic initializer that makes sure a passed index is a valid one for the given StringProtocol.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test OS X platform |
benrimmington
added a commit
to swiftlang/swift-evolution
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.1 Cherry-pick of #22869
rdar://problem/32340799
rdar://problem/32358236
rdar://problem/47985579