Skip to content

test: add a test for ll suffixed types being promoted to ULL #23709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 1, 2019

This addresses the follow up test case discussed in PR23651. Windows
will not promote a macro literal suffixed with ll or i64 to an
unsigned long long even upon an overflow. This tests that the corner
case behaviour for importing a long long literal matches the platform
expectations.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This addresses the follow up test case discussed in PR23651.  Windows
will not promote a macro literal suffixed with `ll` or `i64` to an
unsigned long long even upon an overflow.  This tests that the corner
case behaviour for importing a long long literal matches the platform
expectations.
@compnerd
Copy link
Member Author

compnerd commented Apr 1, 2019

@jrose-apple - as promised a new test for the corner case :-)

@compnerd
Copy link
Member Author

compnerd commented Apr 1, 2019

@swift-ci please test and merge

@compnerd
Copy link
Member Author

compnerd commented Apr 1, 2019

@swift-ci please test macOS platform

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@compnerd compnerd merged commit 3a4dbd6 into swiftlang:master Apr 2, 2019
@compnerd compnerd deleted the long-long-promotion branch April 2, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants