[TestJSONEncoder] Re-enable tests and add a special case for testEncodingDate
#23721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
bendjones
commented
Apr 2, 2019
bendjones
force-pushed
the
bendjones/TestJSONEncoder_fixes
branch
from
2fdde84 to
6aed5ee
Compare
|
@swift-ci smoke test |
itaiferber
reviewed
Apr 4, 2019
bendjones
force-pushed
the
bendjones/TestJSONEncoder_fixes
branch
from
6aed5ee to
2b88f6b
Compare
|
@swift-ci smoke test |
itaiferber
approved these changes
Apr 4, 2019
|
Ben, I realize it might be worth adding an explicit test along with this (inline) not just for |
|
@itai agreed... let me add a counter test here to ensure my new test works as expected. I can pull from the playground. |
…rare condition caused by `snprintf`'s `%g` which `JSONSerialization` uses internally for double values. This bug effects Darwin, FreeBSD, and Linux currently.
bendjones
force-pushed
the
bendjones/TestJSONEncoder_fixes
branch
from
2b88f6b to
c4ee047
Compare
|
@swift-ci smoke test |
bendjones
commented
Apr 4, 2019
| } | ||
|
|
||
| // Test the above `snprintf` edge case evaluation with a known triggering case | ||
| let knownBadDate = Date(timeIntervalSinceReferenceDate: 0.0021413276231263384) |
There was a problem hiding this comment.
@itaiferber added this case which will always pass through the above edge case
|
Cool merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles a rare condition caused by
snprintf's%gwhichJSONSerializationuses internally for double values. This bug effects Darwin, FreeBSD, and Linux currently.