swift-api-digester: diagnose changing of the necessity of new witness table entry as ABI breakage #23731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… table entry as ABI breakage Protocol requirements may not necessarily add new entries to the witness table if it's inherited from super protocol. This patch teaches the json dump to include a flag indicating whether a protocol requirement requires new witness table entry and diagnoses the change of such flag as ABI breakages. rdar://47657204
…rmance is ABI placeholder. ABI placeholders are decls with attribute '@available(macOS 9999, iOS 9999, tvOS 9999, watchOS 9999, *)'. The diagnostics phase could be forgiving for ABI breakages on these decls since they are added recently. This patch adds a new flag to the json file indicating whether a declaration or a conformance is an ABI placeholder. The checking of placeholder is transitive, meaning a decl is an ABI placeholder if its decl context is one. rdar://49502365
nkcsgexi
force-pushed
the
witness-table-entry
branch
from
33a449f to
747d9df
Compare
|
@swift-ci please smoke test |
|
This PR contains several ABI/API checker fixes that require new versions of Json baseline, thus I've regenerated baselines along with the fixes. The same changes will be applied to swift-5.1-branch as well: #23740. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol requirements may not necessarily add new entries to the witness table if
it's inherited from super protocol. This patch teaches the json dump to
include a flag indicating whether a protocol requirement requires new
witness table entry and diagnoses the change of such flag as ABI
breakages.
rdar://47657204