IDE: Remove prepareForRetypechecking() #23733
Merged
+0
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
|
I'm happy with this as long as someone has audited all the code-completion entry points to the typechecker to ensure they go through SanitizeExpr (probably via CSGen). @slavapestov have you done that already? If not, @rintaro could you take a look? |
|
@benlangmuir I had a quick look a few days ago and I think everything goes through generateConstraints() which does SanitizeExpr. Also I'm not proposing taking this for the 5.1 branch, so if there are issues on master hopefully we'll find them before too long. |
|
SGTM, thanks! |
benlangmuir
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.