Assorted bug fixes [5.1] #23754
Merged
Assorted bug fixes [5.1] #23754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slavapestov
commented
Apr 3, 2019
slavapestov
commented
- https://bugs.swift.org/browse/SR-10231
- https://bugs.swift.org/browse/SR-10232
- https://bugs.swift.org/browse/SR-9295
- https://bugs.swift.org/browse/SR-10075
- https://bugs.swift.org/browse/SR-8660
- rdar://problem/48852402
- rdar://problem/44435221
First, if the base parameter is inout or vararg, the derived parameter must be too. Second, we do not allow covariant overrides of inout or vararg parameters. Fixes <https://bugs.swift.org/browse/SR-10231>.
Also, tidy up the code a bit and stop emitting redundant diagnostics for associated types. Fixes <https://bugs.swift.org/browse/SR-10232>.
This is a defensive move to avoid duplicated work and guard against crashes when a multi-expression closure body or TapExpr has not been type checked yet. Fixes <rdar://problem/48852402>.
…lving DynamicSelfType Fixes <https://bugs.swift.org/browse/SR-9295>.
Since 'decl' was already a StructDecl, 'decl->getDeclContext()' was giving us a non-generic module scope context. Fixes <https://bugs.swift.org/browse/SR-10075>.
For now, this means USRs of ParamDecls. Soon, default argument generators for subscripts will need this too. Fixes <https://bugs.swift.org/browse/SR-8660>, <rdar://problem/44435221>.
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
This was referenced Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.