Skip to content

[ParseableInterface][test] Fix path matching in the SDKDependencies and SystemDependencies tests for Windows #23773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Apr 3, 2019

Also don't use -n option of cp as it looks like it's not supported.

log: https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=971

…nd SystemDependencies tests for Windows

Also don't use -n option of cp as it looks like it's not supported.
@nathawes
Copy link
Contributor Author

nathawes commented Apr 3, 2019

@swift-ci please smoke test


// NEGATIVE-NOT: SomeCModule.h
// CHECK: SomeCModule.h
// MODULECACHE-COUNT-2: SystemDependencies-{{[^ ]+}}.swiftmodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a thing? Nifty!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about that feature either!

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@nathawes nathawes merged commit 7d2640f into swiftlang:master Apr 3, 2019
@nathawes nathawes deleted the parseable-tests-windows branch April 3, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants