Allow final on dynamic members #23790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic is about dynamically replacing a method implementiation not overriding. rdar://49535048
|
@swift-ci Please test |
|
Hmm, I missed a digit in the radar number: rdar://49535048 |
|
Build failed |
|
@swift-ci Please test os x platform |
|
Build failed |
slavapestov
reviewed
Apr 4, 2019
Used to be an error. |
|
@swift-ci please test macOS |
|
We don’t require a swift version check when loosening existing restrictions. Also we already shipped swift 5 and it wouldn’t make sense to introduce new behavior changes in -swift-version 5 anyway. I would just make this unconditional and remove the diagnostic. |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Thank you for revising, new version looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic is about dynamically replacing a method implementiation not
overriding.
rdar://49535048