Shims: include math.h on Windows
#23791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
stephentyrone
requested changes
Apr 4, 2019
Since we use `_hypotf` on Windows rather than `__builtin_hyptof` due to a bug in LLVM with the TLI lowering to the wrong builtin, include the math header to get the proper declaration.
compnerd
force-pushed
the
you-know-nothing-clang
branch
from
2a6f698 to
c697ddd
Compare
stephentyrone
approved these changes
Apr 4, 2019
|
@swift-ci please smoke test and merge |
stephentyrone
added a commit
that referenced
this pull request
Apr 4, 2019
* Revert "Merge pull request #23791 from compnerd/you-know-nothing-clang" This reverts commit 5150981, reversing changes made to 8fc305c. * Revert "Merge pull request #23780 from compnerd/math-is-terrible" This reverts commit 2d7fedd, reversing changes made to 0205150. * Revert "Merge pull request #23140 from stephentyrone/mafs" This reverts commit 777750d, reversing changes made to 0c8920e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use
_hypotfon Windows rather than__builtin_hyptofdue toa bug in LLVM with the TLI lowering to the wrong builtin, include the
math header to get the proper declaration.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.