Skip to content

Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… #23806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2019
Merged

Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… #23806

merged 3 commits into from
Apr 8, 2019

Conversation

shahmishal
Copy link
Member

…tdlib and unittests

@shahmishal shahmishal changed the title Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… [WIP] Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… Apr 5, 2019
@shahmishal
Copy link
Member Author

@swift-ci test macOS

1 similar comment
@shahmishal
Copy link
Member Author

@swift-ci test macOS

@shahmishal shahmishal requested a review from gottesmm April 5, 2019 18:04
@shahmishal shahmishal changed the title [WIP] Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… Apr 5, 2019
@shahmishal
Copy link
Member Author

@swift-ci smoke test Linux

@gottesmm
Copy link
Contributor

gottesmm commented Apr 5, 2019

What happens if you use distcc with this instead of sccache? Will distcc work correctly with a just built compiler?

@shahmishal
Copy link
Member Author

Yes, it will work fine with distcc. Distcc will fail to find the compiler on remote server and build locally.

@shahmishal
Copy link
Member Author

@swift-ci test macOS

@gottesmm
Copy link
Contributor

gottesmm commented Apr 7, 2019

That is unfortunate... That is going to make building with distcc really noisy and also make it hard to diagnose when /real/ distcc failures are happening. Can you add make this conditional on an option (enabled by default of course)? Can you make distcc being selected via build-script set that flag?

@gottesmm
Copy link
Contributor

gottesmm commented Apr 7, 2019

Or even hackier, I guess you could check what the CMAKE_C_COMPILER_LAUNCHER actually is and conditionalize based off that?

@shahmishal
Copy link
Member Author

Yes, I was just thinking that. If it contains sscache don’t set it to empty string.

@shahmishal
Copy link
Member Author

I will squash and merge.

@swift-ci smoke test

gottesmm
gottesmm approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this.

@shahmishal shahmishal merged commit c4626ba into master Apr 8, 2019
@shahmishal shahmishal deleted the shahmishal/remove-c-cxx-launcher branch April 8, 2019 19:53
shahmishal added a commit that referenced this pull request Apr 9, 2019
@shahmishal
Un-set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER in s… (
dcb3da1 
#23806)

[CMake] Add check for distcc before setting CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER

(cherry picked from commit c4626ba)
@shahmishal shahmishal mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm gottesmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @gottesmm