Sourcekit-Windows: Look for stdlib correctly #23809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
requested changes
Apr 5, 2019
| MAX_PATH)) | ||
| llvm_unreachable("call to GetModuleFileNameA failed"); | ||
| return llvm::sys::path::parent_path(path); | ||
| path = llvm::sys::path::parent_path(llvm::sys::path::parent_path(path)); |
There was a problem hiding this comment.
You may be getting into undefined behavior here, initializing path from its own memory.
Could you follow similar method to how libclang does this here: https://github.com/apple/swift-clang/blob/078517eab71c45f8a3fc066c02b642bda9c87422/tools/libclang/CIndexer.cpp#L49
There was a problem hiding this comment.
Yeah probably.. fixed now!
On Windows, sourcekitdinproc is placed in the lib directory, not the bin directory.
gmittert
force-pushed
the
SourceLibNotSourceBin
branch
from
2acb15f to
4cf30b8
Compare
akyrtzi
approved these changes
Apr 5, 2019
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, sourcekitdinproc is placed in the lib directory, not the bin
directory.
This fixes a bunch of sourcekit tests on Windows.