Skip to content

[sil] Replace some nstances of SILBuilder(...) with SILBuilderWithSco… #23821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Apr 5, 2019

…pe(...).

The main thing to notice about these changes is that I always picked the debug
scope associated with the location we were using. They should always be in
sync.

…pe(...).

The main thing to notice about these changes is that I always picked the debug
scope associated with the location we were using. They should always be in
sync.
@gottesmm gottesmm requested a review from atrick April 5, 2019 19:32
@gottesmm
Copy link
Contributor Author

gottesmm commented Apr 5, 2019

@swift-ci smoke test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've been saying SILBuilderWithScope should be called SILBuilder. But for now this is progress.

@gottesmm gottesmm merged commit 1131fe1 into swiftlang:master Apr 5, 2019
@gottesmm gottesmm deleted the pr-1984671c8601f1f0c2087a5e22be5f3473533606 branch April 5, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants