Skip to content

[utils] Remove unused method. #23840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drodriguez
Copy link
Contributor

The method was not used anywhere, and Workspace provides a better alternative which gives the full path instead of just the directory name.

This was part of #23257. I’m trying to split the PR in smaller ones to make the reviews easier. Other PRs in this group are #23303, #23803, #23810, and #23822.

The method was not used anywhere, and Workspace provides a better alternative which gives the full path instead of just the directory name.
@drodriguez drodriguez requested a review from compnerd April 6, 2019 20:35
@compnerd
Copy link
Member

compnerd commented Apr 6, 2019

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Apr 6, 2019

CC: @Rostepher @gottesmm

@Rostepher Rostepher self-requested a review April 7, 2019 00:02
Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit e6449a1 into swiftlang:master Apr 7, 2019
@drodriguez drodriguez deleted the build-script-remove-unused-method branch April 8, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants