Class stub fixes and execution tests #23846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rjmccall
reviewed
Apr 8, 2019
| return; | ||
|
|
||
| if (!hasObjCResilientClassStub(IGM, getType())) | ||
| return; |
There was a problem hiding this comment.
Why is the first condition not part of what the second function checks? I could see if this is a definition-vs-use situation, but we're always at the definition site here, right?
There was a problem hiding this comment.
For some reason I factored it so that hasObjCResilientClassStub() asserts the first condition here. I guess it makes sense to change it around.
jrose-apple
reviewed
Apr 8, 2019
|
|
||
| // REQUIRES: executable_test | ||
| // REQUIRES: objc_interop | ||
| // XFAIL: * |
There was a problem hiding this comment.
Is it possible to make this a dynamic condition, like test/Interpreter/SDK/class_getImageName.swift?
There was a problem hiding this comment.
Responded offline.
slavapestov
force-pushed
the
class-stub-fix-and-tests
branch
from
611048d to
df1f47a
Compare
This was an oversight. I was setting the flag but not emitting the pointer at the end.
If a class has resilient metadata from our point of view, it might still not have a class stub, if its entire inheritance chain is defined in a single module. Note that inserting a superclass is still a resilient operation; the only way to change a class from having static metadata to having a class stub is to change it's root class, which is not something we can do resiliently.
Fixes <rdar://49090613>, except they're disabled for the time being.
slavapestov
force-pushed
the
class-stub-fix-and-tests
branch
from
df1f47a to
7c8641c
Compare
|
apple/swift-clang#301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/49090613.