Skip to content

[5.1] Implementation-only import checking #23858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2019
Merged

[5.1] Implementation-only import checking #23858

merged 2 commits into from
Apr 8, 2019

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Apr 8, 2019 •
edited
Loading

Cherry-picking @rjmccall's and my work on basic validation of the use of entities from implementation-only imports, reviewed by @slavapestov and @brentdax.

Part of rdar://problem/48991061

rjmccall and others added 2 commits April 8, 2019 09:48
@rjmccall @jrose-apple
Merge pull request swiftlang#23702 from rjmccall/implementation-only-…
b566dcc 
…diagnostics

[WIP] implementation-only import checking

(cherry picked from commit 6ef5fb5)
@jrose-apple
Merge pull request swiftlang#23722 from jrose-apple/type-disadvantage
0596283 
Implementation-only import checking for types used in decls

(cherry picked from commit be48d64)
@jrose-apple
Copy link
Contributor Author

Still to come (still to be implemented): conformance use checking. See #23808.

@swift-ci Please test

@jrose-apple jrose-apple merged commit b2904fb into swiftlang:swift-5.1-branch Apr 8, 2019
@jrose-apple jrose-apple deleted the 5.1-implementation-only-diagnostics branch April 8, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @rjmccall