Skip to content

[5.1] llvm-tblgen search fixes #23905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 9, 2019

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd added 2 commits April 9, 2019 13:19
A typo snuck into the cross-compiling path and due to the machine that it was
tested on hvaing `/bin/llvm-tblgen`, the build succeeded.  Correct the typo to
ensure that we use the correct tblgen.
The standard library does not depend on the LLVM libraries at runtime.  Do not
perform the search for the LLVM configuration when the tools are not being
built.  This is needed to permit cross-compiling the standard library standalone
for android on a Linux host without building LLVM and Clang for android.
@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

CC: @Rostepher

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

@swift-ci please test

@Rostepher
Copy link
Contributor

So long as testing passes I'm fine with this change.

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - 8d53ef9

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

Please test with following PRs:
#23906

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8d53ef9

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8d53ef9

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 9a16338 into swiftlang:swift-5.1-branch Apr 10, 2019
@compnerd compnerd deleted the standard-library branch April 10, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants