Skip to content

[lldb] Switch PR testing and build to use CMake by default. #23908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2019
Merged

[lldb] Switch PR testing and build to use CMake by default. #23908

merged 2 commits into from
Apr 24, 2019

Conversation

dcci
Copy link
Member

@dcci dcci commented Apr 9, 2019

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@dcci dcci requested a review from shahmishal April 9, 2019 21:26
@dcci
Copy link
Member Author

dcci commented Apr 9, 2019

@swift-ci smoke test

@slavapestov
Copy link
Contributor

Yes, thank you!

@shahmishal shahmishal mentioned this pull request Apr 9, 2019
Closed
@dcci
Copy link
Member Author

dcci commented Apr 9, 2019 

15:19:28 /bin/sh: line 1: 65237 Killed: 9

@shahmishal any idea what's causing this?

@dcci
Copy link
Member Author

dcci commented Apr 9, 2019

@swift-ci smoke test

@shahmishal
Copy link
Member

@dcci Do you have link to the job?

@compnerd
Copy link
Member

The Linux failure:

FAIL: Swift(linux-x86_64) :: Python/build_swift.swift (8145 of 11792)
******************** TEST 'Swift(linux-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /usr/bin/python -m unittest discover -s /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/utils/build_swift/ -t /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/utils/
--
Exit Code: 1

Command Output (stderr):
--
....................................................................................................................................................................................................................................................................................................................................................F..........................................................................................................................................................................FF........................................................................................................................................................................................
======================================================================
FAIL: test_default_value_lldb_build_with_xcode (build_swift.tests.test_driver_arguments.buildbot_incremental,tools=RA,stdlib=RA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/utils/build_swift/tests/test_driver_arguments.py", line 126, in test
    .format(dest, default_value, parsed_value))
AssertionError: Invalid default value for "lldb_build_with_xcode": 1 != 0

======================================================================
FAIL: test_option_lldb_build_with_cmake (build_swift.tests.test_driver_arguments.buildbot_incremental,tools=RA,stdlib=RA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/utils/build_swift/tests/test_driver_arguments.py", line 144, in test
    self.assertEqual(getattr(namespace, option.dest), option.value)
AssertionError: '1' != '0'

======================================================================
FAIL: test_option_lldb_build_with_xcode (build_swift.tests.test_driver_arguments.buildbot_incremental,tools=RA,stdlib=RA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/utils/build_swift/tests/test_driver_arguments.py", line 144, in test
    self.assertEqual(getattr(namespace, option.dest), option.value)
AssertionError: '0' != '1'

----------------------------------------------------------------------
Ran 697 tests in 16.106s

FAILED (failures=3)

--

********************

@dcci
Copy link
Member Author

dcci commented Apr 10, 2019

OK, it just looks like the test has to be updated.

@dcci
Copy link
Member Author

dcci commented Apr 10, 2019

Let's give this another try.

@dcci
Copy link
Member Author

dcci commented Apr 10, 2019

@swift-ci smoke test

@shahmishal
Copy link
Member

@swift-ci smoke test macOS

@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

5 similar comments
@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

@dcci
Copy link
Member Author

dcci commented Apr 11, 2019

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f884348d3089a7114162c3c94fb2dfe485947485

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5b5041d

@dcci
Copy link
Member Author

dcci commented Apr 19, 2019

@swift-ci smoke test

1 similar comment
@dcci
Copy link
Member Author

dcci commented Apr 19, 2019

@swift-ci smoke test

@dcci
Copy link
Member Author

dcci commented Apr 19, 2019

@fredriss the tests I see failing:

12:58:12 Failing Tests (7):
12:58:12     LLDB :: SwiftREPL/Basic.test
12:58:12     LLDB :: SwiftREPL/CFString.test
12:58:12     LLDB :: SwiftREPL/ComputedProperties.test
12:58:12     LLDB :: SwiftREPL/CrashArgs.test
12:58:12     LLDB :: SwiftREPL/UninitVariables.test
12:58:12     lldb-Unit :: Editline/./EditlineTests/EditlineTestFixture.EditlineReceivesMultiLineText
12:58:12     lldb-Unit :: Editline/./EditlineTests/EditlineTestFixture.EditlineReceivesSingleLineText

I'll reproduce them on the laptop.

@dcci
Copy link
Member Author

dcci commented Apr 22, 2019

@swift-ci please smoke test macOS

@dcci
Copy link
Member Author

dcci commented Apr 22, 2019

test with apple/swift-lldb#1494
@swift-ci please smoke test

@dcci
Copy link
Member Author

dcci commented Apr 23, 2019

test with apple/swift-lldb#1499
@swift-ci please smoke test

@dcci
Copy link
Member Author

dcci commented Apr 23, 2019

test with apple/swift-lldb#1499
@swift-ci please smoke test macos

2 similar comments
@dcci
Copy link
Member Author

dcci commented Apr 23, 2019

test with apple/swift-lldb#1499
@swift-ci please smoke test macos

@dcci
Copy link
Member Author

dcci commented Apr 23, 2019

test with apple/swift-lldb#1499
@swift-ci please smoke test macos

@shahmishal
Copy link
Member

test with apple/swift-lldb#1499
@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5b5041d

@dcci
Copy link
Member Author

dcci commented Apr 24, 2019

All the lldb tests are passing, it's only foundation that's failing. I'll pull the trigger.

@dcci dcci merged commit c388946 into swiftlang:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dcci @slavapestov @shahmishal @compnerd @swift-ci