Small CSApply cleanup #23924
Merged
Small CSApply cleanup #23924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
small-csapply-cleanup
branch
from
546974d to
16e296a
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
In a few corner cases we built DeclRefExpr and MemberRefExpr for references to types. These should just be TypeExpr so that SILGen doesn't have to deal with it. This also fixes a bug where a protocol typealias with an unbound generic type could not be accessed properly from expression context, but that is just so incredibly obscure.
Give them substitutions just like with everything else, which eliminates some special cases from SILGen.
slavapestov
force-pushed
the
small-csapply-cleanup
branch
from
16e296a to
7fe577f
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by refactoring.