Skip to content

[cmake] Remove stdlib-experimental from the default install components. #23928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

These are mostly private stdlib APIs. It doesn't really make sense to install
private stdlib APIs by default.

These are mostly private stdlib APIs. It doesn't really make sense to install
private stdlib APIs by default.
@gottesmm
Copy link
Contributor Author

@benlangmuir @shahmishal We do not build these by default/these are private anyways... so to me it makes sense to just make them not part of the /default/ install components.

Your thoughts?

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

I think this is ok. If anyone runs into problems, I will revert.

@gottesmm gottesmm merged commit 2947f75 into swiftlang:master Apr 10, 2019
@gottesmm gottesmm deleted the pr-26093de826f5b69a08f010969911263734b51e8c branch April 10, 2019 18:26
@benlangmuir
Copy link
Contributor

Makes sense, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants