Skip to content

[5.1] Diagnose typealiases of non-public types in inlinable functions #23929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrose-apple
Copy link
Contributor

Cherry-pick of #23912 to the 5.1 branch. Reviewed by @harlanhaskins. (Necessary for private imports work.)

…tlang#23912)

...as a warning, since we didn't check this correctly in Swift 5.
For parseable interfaces, these typealiases won't work at all.

(cherry picked from commit a15dec8)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 33713f4

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test macOS

@jrose-apple jrose-apple merged commit 1842aaa into swiftlang:swift-5.1-branch Apr 10, 2019
@jrose-apple jrose-apple deleted the 5.1-do-we-call-them-type-bookmarks-now branch April 10, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants