Sema: implement isFinal using a request evaluator
#23932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test source compatibility |
slavapestov
reviewed
Apr 10, 2019
|
I reworked @slavapestov I'm looking into remaining issues with some getters that are incorrectly marked as 'final', or not marked when they should be. Let me know if you see something else that seems off with how the accessors are handled. |
slavapestov
reviewed
Apr 11, 2019
| @@ -367,10 +367,6 @@ createCoroutineAccessorPrototype(AbstractStorageDecl *storage, | |||
| if (isStatic) | |||
| accessor->setStatic(); | |||
|
|
|||
| // The accessor is final if the storage is. | |||
| if (storage->isFinal()) | |||
| makeFinal(ctx, accessor); | |||
There was a problem hiding this comment.
makeFinal() should be dead code now, you can remove it from its .cpp and .h files
slavapestov
reviewed
Apr 11, 2019
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
Add the request evaluator `IsFinalRequest` to lazily determine if a `ValueDecl` is final.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
xymus
changed the title
isFinal using a request evaluatorisFinal using a request evaluator
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Aug 6, 2019
…ed members of a final class I believe this was fixed with swiftlang#23932. 5.1 had an inconsistency here because the synthesized declaration was not marked as final; we would sometimes check if a method itself was final, other times we would check if both the method and the class were final. Lucky it worked out so that the emitted vtable entry did not appear to ever have been used. Make sure this behavior doesn't change going forward with a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the request evaluator
IsFinalRequestto lazily determine if aValueDeclis final.