Skip to content

Undo "Disable ASan in coroutine functions; it interferes with splitting." (3a4185c). #23951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kubamracek
Copy link
Contributor

This is no longer needed because we now make sure to run the coroutine lowering pass before ASan/TSan instrumentation passes.

…ng." (3a4185c).

This is no longer needed because we now make sure to run the coroutine lowering pass before ASan/TSan instrumentation passes.
@kubamracek kubamracek requested a review from rjmccall April 11, 2019 16:37
@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kubamracek kubamracek merged commit a1aced9 into swiftlang:master Apr 11, 2019
@kubamracek kubamracek deleted the undo-disabled-asan-in-coroutines branch April 11, 2019 22:16
kubamracek added a commit to kubamracek/swift that referenced this pull request Apr 15, 2019
…ng." (3a4185c). (swiftlang#23951)

This is no longer needed because we now make sure to run the coroutine lowering pass before ASan/TSan instrumentation passes.
kubamracek added a commit that referenced this pull request Apr 15, 2019
…ng." (3a4185c). (#23951) (#24039)

This is no longer needed because we now make sure to run the coroutine lowering pass before ASan/TSan instrumentation passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants