Skip to content

[ModuleInterfaces] Rename 'parseable interfaces' to 'module interfaces' #23969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2019
Merged

[ModuleInterfaces] Rename 'parseable interfaces' to 'module interfaces' #23969

merged 4 commits into from
Apr 13, 2019

Conversation

harlanhaskins
Copy link
Contributor

...currently only in diagnostics, command-line flags, and environment variables.

rdar://49359734

@jrose-apple
Copy link
Contributor

Should this happen at the same time as the change to "compiled module"?

jrose-apple
jrose-apple reviewed Apr 11, 2019
View reviewed changes
@harlanhaskins
Copy link
Contributor Author

Would you say, e.g. module file was created by an older version of the compiler should become compiled module file was created by an older version of the compiler?

@jrose-apple
Copy link
Contributor

Would you say, e.g. module file was created by an older version of the compiler should become compiled module file was created by an older version of the compiler?

Maybe just "compiled module was created by an older version of the compiler"?

Harlan Haskins added 4 commits April 11, 2019 18:05
[ModuleInterfaces] Remove 'parseable' from command-line flags
e545698 
Leave the old flag in as an alias to the new flag, for transition
purposes. Also go ahead and remove the long-deprecated and unused
`emit-interface-path`.

Part of rdar://49359734
[ModuleInterface] Remove 'parseable interface' from diagnostics
ea7e7e9 
Part of rdar://49359734
[test] [ModuleInterfaces] Get tests passing with new diagnostics
6d72977
[ModuleInterfaces] Replace 'module file' with 'compiled module'
150ad99 
...only in diagnostics. And make the tests pass.

rdar://49359734
@harlanhaskins
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a2b46b3cda480924420bb9bee96f33e2258c9039

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a2b46b3cda480924420bb9bee96f33e2258c9039

@harlanhaskins
Copy link
Contributor Author

Seems to not be my issue.

@swift-ci please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 150ad99

@harlanhaskins
Copy link
Contributor Author

Let's try one more time.

@swift-ci please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 150ad99

@harlanhaskins
Copy link
Contributor Author

IO failure on output stream: No space left on device

Once more unto the breach.
@swift-ci please smoke test Linux

@harlanhaskins
Copy link
Contributor Author

Passed on Linux and macOS (finally)

@harlanhaskins harlanhaskins merged commit 3586952 into swiftlang:master Apr 13, 2019
@harlanhaskins harlanhaskins mentioned this pull request Apr 16, 2019
Merged
This was referenced May 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

@nathawes nathawes nathawes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harlanhaskins @jrose-apple @swift-ci @nathawes