Miscellaneous cleanup and consolidation for implementation-only checking #23972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Apr 11, 2019
jrose-apple
commented
- Adjust the implementation-only diagnostics to sound more similar
- Don't bother checking implementation-only import use for accessors
- Consolidate names of implementation-only checking functions as "exportability"
John and I had slightly different styles when adding these; better to keep them in harmony.
Their associated AbstractStorageDecl is already being checked, and will produce a better error.
Another place where John and I used different terms.
|
@swift-ci Please smoke test |
|
That second one's actually semantics-changing, but it's also the simplest diff. |
beccadax
approved these changes
Apr 11, 2019
slavapestov
approved these changes
Apr 12, 2019
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Apr 19, 2019
…ly-implementation---only Miscellaneous cleanup and consolidation for implementation-only checking (cherry picked from commit d4a5740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.