Skip to content

SourceKit: Account for existing braces when expanding closure placeholders #23978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

SourceKit: Account for existing braces when expanding closure placeholders #23978

merged 1 commit into from
Apr 25, 2019
+46 −16

Conversation

AnthonyLatsis
Copy link
Collaborator

@rintaro rintaro requested a review from nkcsgexi April 12, 2019 16:26
@AnthonyLatsis
Copy link
Collaborator Author

@nkcsgexi Reminder

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 23, 2019 •
edited
Loading

@benlangmuir It looks like Xi has been busy lately, so I am tagging you in case you find the time to take a glance before Xi joins in.

@benlangmuir
Copy link
Contributor

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator Author

Thanks a lot, Ben.

@benlangmuir benlangmuir merged commit 27b12bf into swiftlang:master Apr 25, 2019
@AnthonyLatsis AnthonyLatsis deleted the expand-closure-check-braces branch February 17, 2022 21:04
@AnthonyLatsis AnthonyLatsis mentioned this pull request Apr 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @benlangmuir