SILGen: Fix function conversions involving DynamicSelfType #23985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
dynamic-self-thunks
branch
from
df34244 to
58eaebd
Compare
Also, NodePrinter was printing the 'from' and 'to' type backwards, so fix that.
This was partially implemented but the check looked at the lowered types and not the AST types, and DynamicSelfType is erased at the top level of a lowered type. Also use the new mangling for reabstraction thunks with self, to ensure we don't emit the same symbol with two different lowered types. Fixes <https://bugs.swift.org/browse/SR-10309>, <rdar://problem/49703441>.
…turing DynamicSelfType If a thunk's type involves DynamicSelfType, a second value must be captured of metatype type.
We can reuse the same logic that we have for reabstraction thunks here.
slavapestov
force-pushed
the
dynamic-self-thunks
branch
from
58eaebd to
099bd8e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@shahmishal Known problem? |
|
@swift-ci Please clean test macOS |
|
Build failed |
Yes, I will add a fix for this soon. |
|
@swift-ci Please clean test macOS |
|
Build failed |
|
@swift-ci Please clean test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already implemented but the check looked at the lowered
types and not the AST types, and DynamicSelfType is erased at the
top level of a lowered type.
Fixes https://bugs.swift.org/browse/SR-10309, rdar://problem/49703441.