Fix-it for var parameter doesn't delete enough whitespace
#24025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the patch. A few notes
|
|
Come to think of it, this diagnostic is from Swift 2-3 and we no longer support that mode. You can probably refactor the “invalid parameter attribute” diagnostic to instead detect keywords and insert some `` quotes. |
|
I'm picking up work on this pull request in #24059. There's some further discussion of the issue there. |
|
This was resolved in #24059. Closing this for now. If there's something in here that was missed though feel free to reopen 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-10293.