[5.1][CSSimplify] Reject key path if root type is AnyObject #24026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect situations where `AnyObject` is attempted to be used as a root type of the key path early and diagnose via new diagnostics framework. Resolves: rdar://problem/49413561 (cherry picked from commit 072e84a)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
Ah right, I need to cherry-pick changes to |
… declaration to have a fix We should be able to attach fixes to overload choices that don't refer to declarations e.g. keypath applications which refer to `AnyObject` is a base type. (cherry picked from commit 374a10c)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect situations where
AnyObjectis attempted to be used as a root type of the key pathearly and diagnose via new diagnostics framework.
Resolves: rdar://problem/49413561
(cherry picked from commit 072e84a)