Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
CC: @dabrahams
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160404/001621.html
${BUILD_DIR}/lib/Basic/SwiftRevision.inc
used to be re-generated every timegit revision "hash" has changed. I feel, that is superfluous while developing.
With this change,
{LLVM,Clang,Swift}Revision.inc
generation is doneat configure time, instead of build time. That means:
--reconfigure
: re-link and refresh--version
output--reconfigure
: no re-link and remain old--version
outputAFAIK, every CI build has
--reconfigure
or perform scratch build.So, this change should not affect CI bot behavior.
I confirmed:
Before merging this pull request to apple/swift repository: