Skip to content

doc-serialization: exclude non-public decls when serializing module group info. #24040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

nkcsgexi
Copy link
Contributor

This reduces the size of x86_64.swiftdoc about 10%.

rdar://48689311

…roup info.

This reduces the size of x86_64.swiftdoc about 10%.

rdar://48689311
@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi nkcsgexi requested a review from jrose-apple April 15, 2019 19:11
@nkcsgexi nkcsgexi merged commit 2fbcc20 into swiftlang:master Apr 15, 2019
@jrose-apple
Copy link
Contributor

At first glance the logic looks identical before and after to me. What decls were affected by this change?

@jrose-apple
Copy link
Contributor

Ah, I see, the access control check was moved before the GroupInfo check.

@nkcsgexi nkcsgexi deleted the exlude-private-doc branch April 15, 2019 22:47
@compnerd
Copy link
Member

compnerd commented Apr 17, 2019

This broke the windows build! See #24092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants