[5.1] doc-serialization: exclude non-public decls when serializing module group info. #24047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup info. This reduces the size of x86_64.swiftdoc about 10%. rdar://48689311
|
@swift-ci please test |
|
Build failed |
|
@swift-ci Please clean test Linux platform |
akyrtzi
reviewed
Apr 16, 2019
| @@ -4,7 +4,16 @@ | |||
| // RUN: not %target-swift-frontend -emit-module %s -module-name HasArray -o %t -module-cache-path %t/mcp -group-info-path %S/Inputs/corrupted_group_info.json -emit-module-doc &> %t/result.txt | |||
| // RUN: %FileCheck %s -check-prefix=CORRUPTED < %t/result.txt | |||
|
|
|||
| public protocol P {} | |||
| // RUN: %target-swift-frontend -emit-module %s -module-name HasArray -o %t -module-cache-path %t/mcp -group-info-path %S/Inputs/group_info.json -emit-module-doc &> %t/result.txt | |||
| // RUN: strings %t/HasArray.swiftdoc > %t/doc_strings.txt | |||
There was a problem hiding this comment.
@shahmishal @compnerd should use of strings binary in the test be guarded with // REQUIRES: shell ?
There was a problem hiding this comment.
No, you should use llvm-strings instead (using the substitution %llvm-strings).
There was a problem hiding this comment.
Ah nice, I wasn't aware of this, @nkcsgexi could you make such a change ?
akyrtzi
requested changes
Apr 16, 2019
| @@ -4,7 +4,16 @@ | |||
| // RUN: not %target-swift-frontend -emit-module %s -module-name HasArray -o %t -module-cache-path %t/mcp -group-info-path %S/Inputs/corrupted_group_info.json -emit-module-doc &> %t/result.txt | |||
| // RUN: %FileCheck %s -check-prefix=CORRUPTED < %t/result.txt | |||
|
|
|||
| public protocol P {} | |||
| // RUN: %target-swift-frontend -emit-module %s -module-name HasArray -o %t -module-cache-path %t/mcp -group-info-path %S/Inputs/group_info.json -emit-module-doc &> %t/result.txt | |||
| // RUN: strings %t/HasArray.swiftdoc > %t/doc_strings.txt | |||
There was a problem hiding this comment.
Ah nice, I wasn't aware of this, @nkcsgexi could you make such a change ?
`strings` is not available, use `%llvm-strings` which uses the LLVM `strings` implementation instead.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of x86_64.swiftdoc about 10%.
rdar://48689311