Introduce "can bind to noescape" bit on TypeVariableType #24082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
We have a systemic class of issues where noescape types end up bound to type variables in places that should not. The existing diagnostic for this is ad-hoc and duplicated in several places but it doesn't actually address the root cause of the problem. For now, I've changed all call sites of createTypeVariable() to set the new flag. I plan on removing enough occurrences of the flag to replicate the old diagnostics. Then we can continue to refine this over time.
slavapestov
force-pushed
the
typevar-noescape-fix
branch
from
9cfb0fb to
f3bb3d9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All type variables except for a couple currently set this bit. Over time, we should refine the set that has them.
Fixes https://bugs.swift.org/browse/SR-9991.