Improve -debug-constraints output for key path components
#24084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
reviewed
Apr 17, 2019
xedin
approved these changes
Apr 17, 2019
xedin
reviewed
Apr 17, 2019
There are two places where we can dump an expr with types from the constraint solver. There should only be one.
ASTDumper doesn’t have any way to look up key path component types in the constraint solver, so they’re currently shown as null. This change adds a hook to look them up and looks in the key path component’s FunctionResult locator, which is where subscripts already keep their return type.
Previously, nearly all of the type vars for a key path component were dumped under the KeyPathExpr itself, whcih made them difficult to differentiate when debugging. Attach each one to “key path component #N -> function result” instead. # Conflicts: # lib/Sema/CSGen.cpp
beccadax
commented
Apr 17, 2019
beccadax
force-pushed
the
whos-that-key-path-component
branch
from
f1c82f1 to
849b12e
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Avoids digging through the long list of type vars to find the ones related to key path components when dumping an expression.
We’ll use this instead of the function result, except for subscript components, which are already structured similarly to subscript expressions.
beccadax
force-pushed
the
whos-that-key-path-component
branch
from
849b12e to
760d4be
Compare
|
Missed a bug, and simplified history while I was at it. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test source compatibility |
|
The test failure didn't include any useful information; I'm hoping a re-run will either fix the issue or give me more leads. @swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During constraint debugging, the AST dumper currently shows all
KeyPathExprcomponents with<null>types because it can't look into the constraint system to find type variables. This PR improves this debugging experience, which should help us fight some of the bugs in key path type-checking.Before
After